Fix users getting stuck on welcome screen #7726
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
buggmagnet
approved these changes
Feb 27, 2025
There was a problem hiding this comment.
Reviewable status: 0 of 1 files reviewed, all discussions resolved
pinkisemils
approved these changes
Mar 3, 2025
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved
rablador
force-pushed
the
new-user-can-get-stuck-on-welcome-screen-ios-1084
branch
from
ec6732a to
dc95ff5
Compare
buggmagnet
approved these changes
Mar 3, 2025
There was a problem hiding this comment.
Reviewable status:
rablador
force-pushed
the
new-user-can-get-stuck-on-welcome-screen-ios-1084
branch
from
dc95ff5 to
683b7e3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this needs to be done
Reproduce:
It can be solved by logging out and back in, but this is not a good first experience.
What needs to be done
isShownOnboardingin AppPreferences should be set to true as soon as the user has been past the Welcome view.Check if the user has time before presenting WelcomeView.Acceptance criteria
Reproducing the above steps should lead the user to the main view instead of back to the welcome view.
This change is